On 01/04/2019 05:56 PM, Radostin Stoyanov wrote:
Closes #7

Reported-by: @loops
Signed-off-by: Radostin Stoyanov <[email protected]>
---
  src/virtBootstrap/virt_bootstrap.py | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/src/virtBootstrap/virt_bootstrap.py 
b/src/virtBootstrap/virt_bootstrap.py
index a0b97a2..4bfa95d 100755
--- a/src/virtBootstrap/virt_bootstrap.py
+++ b/src/virtBootstrap/virt_bootstrap.py
@@ -124,6 +124,9 @@ def bootstrap(uri, dest,

      if not os.path.exists(dest):
          os.makedirs(dest)
+    elif os.path.abspath(dest) == "/":  # Don't overwrite root
+        logger.error("Unpack to root directory is not allowed")
+        sys.exit(1)
      elif not os.path.isdir(dest):  # Show error if not directory
          logger.error("Destination path '%s' is not directory.", dest)
          sys.exit(1)

Makes sense to me, rm has similar safety checks

Reviewed-by: Cole Robinson <[email protected]>

Thanks,
Cole

_______________________________________________
virt-tools-list mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/virt-tools-list

Reply via email to