On 12/16/2011 12:20 PM, Laine Stump wrote: > (V2 changes "pc-0.13" to "pc-0.14" per the discussion in email. Also, > the change to the test files was moved to a separate patch which was > also pushed upstream.) > > This addresses https://bugzilla.redhat.com/show_bug.cgi?id=754772 . > It should only be applied to Fedora builds of libvirt, F15 and later.
ACK. > > Background: > > During the lifetime of Fedora 13, some features were backported into > the F13 build of qemu-kvm from upstream. These features were part of > the functionality of machine type "pc-0.13" in upstream qemu-kvm, so a > special "fedora-13" machine type was created for the F13 qemu-kvm. > Since "fedora-13" became the new "canonical machine type", all new > domains created with F13 libvirt tools by default contained that > machine type in their configuration file. > > In Fedora 14, a patch was made to qemu to treat the fedora-13 machine > type as equivalent to "pc-0.13". When Fedora 15 was released, this was > inadvertantly changed to make it equivalent to "pc-0.14". s/inadvertantly/inadvertently/ > > With the release of Fedora 16, qemu-kvm initially removed support for > this machine type, which caused failure of many guest configurations > to start. qemu-kvm subsequently re-added the patch to support > fedora-13 (as equivalent to pc-0.14), but with the promise that they > could remove it with the release of Fedora 17. (see > https://bugzilla.redhat.com/show_bug.cgi?id=748218 ). > > Solution: > > In order to create a repeat of the recent problems, prior to F17 > existing guest configurations need to be updated to change fedora-13 > to pc-0.14 (which has been determined to be equivalent for all > practical purposes in both F15 and F16). That's what this patch does: > > 1) Each time libvirtd is started, it calls virDomainLoadAllConfigs() > which calls virDomainLoadConfig(); this function has been modified to > check for os.machine == "fedora-13", and change it to "pc-0.14" then > write the updated config back to disk. > > 2) Also, any other time a domain definition is parsed, the parsed > version in memory is changed to turn "fedora-13" into "pc-0.14". This > handles domains that had been saved to disk prior to the upgrade, and > are subsequently restarted. > > 3) Finally, whenever a domain definition is formatted into a string, > any occurence of fedora-13 is replaced with pc-0.14 *directly in the s/occurence/occurrence/ -- Eric Blake [email protected] +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
_______________________________________________ virt mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/virt
