We specify that the device MUST reject setting up classic indicators
after two-stage indicators have been setup, which is clearly a
device conformance statement but isn't actually listed as one.
Fix this.

VIRTIO-157

Reviewed-by: Halil Pasic <pa...@linux.vnet.ibm.com>
Reviewed-by: Pierre Morel <pmo...@linux.vnet.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.h...@de.ibm.com>
---
 conformance.tex | 1 +
 content.tex     | 1 +
 2 files changed, 2 insertions(+)

diff --git a/conformance.tex b/conformance.tex
index f59e360..ca08486 100644
--- a/conformance.tex
+++ b/conformance.tex
@@ -200,6 +200,7 @@ A Channel I/O device MUST conform to the following 
normative statements:
 \item \ref{devicenormative:Virtio Transport Options / Virtio over channel I/O 
/ Device Initialization / Setting the Virtio Revision}
 \item \ref{devicenormative:Virtio Transport Options / Virtio over channel I/O 
/ Device Initialization / Configuring a Virtqueue}
 \item \ref{devicenormative:Virtio Transport Options / Virtio over channel I/O 
/ Device Initialization / Communicating Status Information}
+\item \ref{devicenormative:Virtio Transport Options / Virtio over channel I/O 
/ Device Initialization / Setting Up Indicators / Setting Up Classic Queue 
Indicators}
 \item \ref{devicenormative:Virtio Transport Options / Virtio over channel I/O 
/ Device Initialization / Setting Up Indicators / Setting Up Two-Stage Queue 
Indicators}
 \item \ref{devicenormative:Virtio Transport Options / Virtio over channel I/O 
/ Device Operation / Host->Guest Notification / Notification via Adapter I/O 
Interrupts}
 \item \ref{devicenormative:Virtio Transport Options / Virtio over channel I/O 
/ Device Operation / Guest->Host Notification}
diff --git a/content.tex b/content.tex
index 546bef7..657b9cd 100644
--- a/content.tex
+++ b/content.tex
@@ -2787,6 +2787,7 @@ notification, the driver uses the CCW_CMD_SET_IND command,
 pointing to a location containing the guest address of the
 indicators in a 64 bit value.
 
+\devicenormative{\subparagraph}{Setting Up Classic Queue Indicators}{Virtio 
Transport Options / Virtio over channel I/O / Device Initialization / Setting 
Up Indicators / Setting Up Classic Queue Indicators}
 If the driver has already set up two-staged queue indicators via the
 CCW_CMD_SET_IND_ADAPTER command, the device MUST post a unit check
 with command reject to any subsequent CCW_CMD_SET_IND command.
-- 
2.11.0


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org

Reply via email to