> From: Michael S. Tsirkin <[email protected]> > Sent: Wednesday, February 15, 2023 7:20 PM > > On Wed, Feb 15, 2023 at 09:53:55PM +0000, Parav Pandit wrote: > > > > > From: Michael S. Tsirkin <[email protected]> > > > Sent: Wednesday, February 15, 2023 8:00 AM > > > > > > btw did you try to generate a diff pdf? when changing labels it is > > > sometimes necessary to keep old ones around too as diff needs old and > new links to work. > > > > I generated the new pdf before pushing the patch. > > I couldn't generate the diff pdf using ./makediffpdf.sh > > > > I get error on running makediff.sh virtio.tex > > > > Warning: command \@chapapp containing @ found in > > Warning: virtio.tex. > > Warning: consider using --makeatletter if the result is not compilable. > > Warning: command \@chapapp containing @ found in > > Warning: ./main.tex. > > Warning: consider using --makeatletter if the result is not compilable. > > Submodule path 'latexdiff' not initialized Maybe you want to use > > 'update --init'? > > make: Entering directory '/images/parav/upstream/virtio-spec/latexdiff' > > make: *** No rule to make target 'mkdirs'. Stop. > > make: Leaving directory '/images/parav/upstream/virtio-spec/latexdiff' > > ./makediff.sh: line 51: ./latexdiff-fast: No such file or directory > > > Hmm. does this help: > Works great. Thank you. Was able to find out fixing the change log. I posted the fix up patch at [1].
Please review. [1] https://lists.oasis-open.org/archives/virtio-dev/202302/msg00331.html --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
