On Tue, Mar 28 2023, Parav Pandit <[email protected]> wrote: > max_num field reflects the maximum queue size/depth. Hence align name of > this field with similar field in PCI and MMIO transport to > max_queue_size. > Similarly rename 'num' to 'size'. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163 > Signed-off-by: Parav Pandit <[email protected]> > > --- > changelog: > v8->v9: > - replaced 'named' as 'known' > v3->v4: > - moved note to comment > --- > transport-ccw.tex | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/transport-ccw.tex b/transport-ccw.tex > index c492cb9..488c46c 100644 > --- a/transport-ccw.tex > +++ b/transport-ccw.tex > @@ -237,12 +237,12 @@ \subsubsection{Configuring a > Virtqueue}\label{sec:Virtio Transport Options / Vir > \begin{lstlisting} > struct vq_config_block { > be16 index; > - be16 max_num; > + be16 max_queue_size; /* Previously known as max_num */
Nit: the comment should probably start with a lower-case 'p', as it is not a complete sentence (further instances of this below). Otherwise, Reviewed-by: Cornelia Huck <[email protected]> --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
