On Mon, Jun 19, 2023 at 04:39:16PM +0000, Parav Pandit wrote:
>
>
> > From: Michael S. Tsirkin <m...@redhat.com>
> > Sent: Monday, June 19, 2023 12:38 PM
>
> > >
> > > +\field{legacy_q_notify_supported} when set to 1, indicates that the
> > > +device supports legacy queue notifications at this notification
> > > +location. Legacy Queue Notification address is derived within a BAR for a
> > virtqueue:
> > > +
> > > +\begin{lstlisting}
> > > + cap.offset
> > > +\end{lstlisting}
> > > +
> > > \devicenormative{\paragraph}{Notification capability}{Virtio
> > > Transport Options / Virtio Over PCI Bus / PCI Device Layout / Notification
> > capability} The device MUST present at least one notification capability.
> > >
> >
> > I was hoping that we can avoid touching transport-pci.tex completely, this
> > is
> > why I wanted to reuse VIRTIO_PCI_CAP_NOTIFY_CFG.
>
> It is reused, but it doesnt come for free.
> Do you want to re-consider AQ notify query command?
> Or continue as proposed in v6?
If we can't just make it come for free then maybe
VIRTIO_PCI_CAP_LEGACY_NOTIFY_CFG is better, we can just list the number
in the common section and then link to the description in the new
section.
I also feel we want ability to have such a capability in the owner too.
Would prefer including it now though I guess we can add it as an
extension.
--
MST
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org
