> On Thu, Feb 20, 2020 at 08:47:02PM +0900, Misono Tomohiro wrote: > > This fixes the xattr operation for directory and special files (which > > can be tested by xfstests generic/062 with -o xattr option). > > > > The overall logic is switched back to the same as v1 in favor of > > performance (i.e. keep original implementation for regular > > files/directories) but I add a cleanup patch to improve readability as > > requested by Vivek. > > > > Known issue is that if xattr enabled, seek sanity tests (generic/285, > > 436) will fail. However, I understand this is not a very serious bug > > like data corruption so leave it for now. > > > > One question; I remove error handling of fchdir() in v3 since I > > believe fchdir to proc_self_fd/root.fd cannot fail in the situation > > but should I add error handling? > > > > change v2 -> v3: > > - rebased to current dev branch > > - add cleanup path (first one) to simplify main patch (second patch) > > - restore the logic of v1 in favor of performance > > (as a result seek sanity test failure is not fixed by this series) > > - remove error handling of fchdir > > - drop ACL fix included in v2 for now to focus xattr > > > > v2 patch: > > https://www.redhat.com/archives/virtio-fs/2020-January/msg00131.html > > Hi Misono, > > This patchset passes my basic test. I have not run xfstests. I am relying on > your testing. > > Can you please take care of minor nits I had and repost patces. I will ack it.
Thanks for review/comments. I will update the patches and send them soon. Thanks, Misono > > Thanks > Vivek > > > > > Thanks! > > > > Misono Tomohiro (2): > > virtiofs: passthrough_ll: cleanup getxattr/listxattr > > virtiofs: Fix xattr operations > > > > tools/virtiofsd/fuse_virtio.c | 13 +++ > > tools/virtiofsd/passthrough_ll.c | 141 +++++++++++++++---------------- > > tools/virtiofsd/seccomp.c | 6 ++ > > 3 files changed, 87 insertions(+), 73 deletions(-) > > > > -- > > 2.21.1 > > > > > > _______________________________________________ > > Virtio-fs mailing list > > [email protected] > > https://www.redhat.com/mailman/listinfo/virtio-fs _______________________________________________ Virtio-fs mailing list [email protected] https://www.redhat.com/mailman/listinfo/virtio-fs
