On 12/03/15 12:09 AM, DRC wrote:
> It's sort of pedantic. The assumption is that, in the first three
> tests, the Pixmap is 3D, because it isn't meaningful to test XCopyArea()
> otherwise (2D->2D would pass through to X11 without VirtualGL's
> interference.) I don't have any real problem changing this, but I think
> the first two (Window->Pixmap and Pixmap->Window) should be changed as well.
Right. Updated in attached patch:
We go from:
printf("Pixmap->Window: ");
printf("Window->Pixmap: ");
printf("Pixmap->Pixmap: ");
printf("GLX Pixmap->2D Pixmap: ");
printf("Deleted GLX Pixmap->2D Pixmap: ");
To:
printf("GLX Pixmap->Window: ");
printf("Window->GLX Pixmap: ");
printf("GLX Pixmap->GLX Pixmap: ");
printf("GLX Pixmap->2D Pixmap: ");
printf("Deleted GLX Pixmap->2D Pixmap: ");
The pedantry originated from one point where I'd wasted time checking
if there was some nuance to why ealier tests said just "Pixmap" and
later tests said "GLX Pixmap".
-Nathan
>From 3962c19e5a52fcfbb54943ebc128fb4b2d736419 Mon Sep 17 00:00:00 2001
From: Nathan Kidd <nk...@opentext.com>
Date: Wed, 1 Aug 2012 22:10:20 -0400
Subject: [PATCH 4/8] Clarify glx pixmap unit test descriptions
---
server/fakerut.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/server/fakerut.cpp b/server/fakerut.cpp
index 61bb41f..891fe2f 100644
--- a/server/fakerut.cpp
+++ b/server/fakerut.cpp
@@ -2067,7 +2067,7 @@ int offScreenTest(void)
try
{
- printf("Pixmap->Window: ");
+ printf("GLX Pixmap->Window: ");
if(!(glXMakeContextCurrent(dpy, glxpm0, glxpm0, ctx)))
_error("Could not make context current");
glXUseXFont(fontInfo->fid, minChar, maxChar-minChar+1,
@@ -2093,7 +2093,7 @@ int offScreenTest(void)
try
{
- printf("Window->Pixmap: ");
+ printf("Window->GLX Pixmap: ");
if(!(glXMakeContextCurrent(dpy, glxwin, glxwin, ctx)))
_error("Could not make context current");
glXUseXFont(fontInfo->fid, minChar, maxChar-minChar+1,
@@ -2125,7 +2125,7 @@ int offScreenTest(void)
try
{
- printf("Pixmap->Pixmap: ");
+ printf("GLX Pixmap->GLX Pixmap: ");
if(!(glXMakeContextCurrent(dpy, glxpm0, glxpm0, ctx)))
_error("Could not make context current");
glXUseXFont(fontInfo->fid, minChar, maxChar-minChar+1,
--
1.9.1
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
VirtualGL-Devel mailing list
VirtualGL-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/virtualgl-devel
