On Thu, 2007-03-29 at 11:53 -0400, James Morris wrote:
> At http://namei.org/misc/lguest/patches/time/v04/
>
> Just a resync to the latest upstream lguest patch queue, after some fun
> with bare metal bugs and assorted churn.
Hi James!
Thanks for the patch! Nothing major to add, just some questions
mainly...
> diff --git a/drivers/lguest/core.c b/drivers/lguest/core.c
> index d8f136a..344b455 100644
> --- a/drivers/lguest/core.c
> +++ b/drivers/lguest/core.c
> @@ -393,6 +393,23 @@ int find_free_guest(void)
> return -1;
> }
>
> +void guest_clockevent(struct lguest *lg, const ktime_t __user *u)
interrupts_and_traps.c might be a better place for this? Similarly the
code currently in lguest_user.c, which is mainly for code dealing
with /dev/lguest.
> + case LHCALL_CLOCKEVENT:
> + guest_clockevent(lg, (ktime_t __user *)regs->edx);
> + break;
Perhaps LHCALL_SET_CLOCKEVENT is a better name? Or were you thinking of
extending it?
> --- a/drivers/lguest/lguest.c
> +++ b/drivers/lguest/lguest.c
> @@ -62,6 +64,7 @@ #include <asm/e820.h>
> #include <asm/pda.h>
> #include <asm/asm-offsets.h>
> #include <asm/mce.h>
> +#include "lg.h"
Hmm, this implies we've knotted the headers somehow. "lg.h" is supposed
to be the internal header for lg.ko. Perhaps something needs to be
moved to linux/lguest.h?
Thanks!
Rusty.
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/virtualization
