On Wed, 13 May 2009 01:03:30 am Michael S. Tsirkin wrote:
> On Wed, May 13, 2009 at 12:00:02AM +0930, Rusty Russell wrote
> > and perhaps consider
> > varargs for the callbacks (or would that be too horrible at the
> > implementation end?)
> >
> > Thanks,
> > Rusty.
>
> Ugh ... I think it will be. And AFAIK gcc generates a lot of code
> for varargs - not something we want to do in each interrupt handler.
Err, no I mean for find_vqs: eg.
(block device)
err = vdev->config->find_vqs(vdev, 1, &vblk->vq, blk_done);
(net device)
err = vdev->config->find_vqs(vdev, 3, vqs, skb_recv_done,
skb_xmit_done, NULL);
A bit neater for for the single-queue case.
Cheers,
Rusty.
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/virtualization
