Rusty Russell wrote:
> On Sun, 17 May 2009 03:57:01 pm Avi Kivity wrote:
>
>> Rusty Russell wrote:
>>
>>> +static void adjust_threshold(struct vring_virtqueue *vq,
>>> + unsigned int out, unsigned int in)
>>> +{
>>> + /* There are really two species of virtqueue, and it matters here.
>>> + * If there are no output parts, it's a "normally full" receive queue,
>>> + * otherwise it's a "normally empty" send queue. */
>>>
>> This comment is true for networking, but not for block. ++overkill with
>> a ->adjust_threshold op.
>>
>
> No, it's true for block. It has output parts, so we should reduce threshold
> when it's full. Network recvq is an example which should reduce threshold
> when it's empty.
>
You mean the header that contains the sector number? It's a little
incidental, but I guess it works.
--
error compiling committee.c: too many arguments to function
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/virtualization
