On Tue, 2009-06-02 at 09:13 +0100, Mark McLoughlin wrote: > On Fri, 2009-05-29 at 23:46 +0930, Rusty Russell wrote: > > The virtio_net driver is complicated by the two methods of freeing old > > xmit buffers (in addition to freeing old ones at the start of the xmit > > path). > > > > The original code used a 1/10 second timer attached to xmit_free(), > > reset on every xmit. Before we orphaned skbs on xmit, the > > transmitting userspace could block with a full socket until the timer > > fired, the skb destructor was called, and they were re-woken. > > The timer was actually added to solve a hang when trying to unload > nf_conntrack AFAIR - nf_conntrack was blocking on the skb being freed > and we never actually freed it. > > I think skb_orphan() is enough to prevent this, is it?
Oops, I meant: I don't think skb_orphan() is enough to prevent this, is it? Cheers, Mark. _______________________________________________ Virtualization mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/virtualization
