From: Haiyang Zhang <[email protected]>

Subject: staging: hv: Fix error checking in channel.c
Fixed errors in return value checking code, which caused vmbus channel
not functioning.

Cc: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Haiyang Zhang <[email protected]>
Signed-off-by: Hank Janssen <[email protected]>

---
 drivers/staging/hv/channel.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/hv/channel.c b/drivers/staging/hv/channel.c
index 12c351e..f047c5a 100644
--- a/drivers/staging/hv/channel.c
+++ b/drivers/staging/hv/channel.c
@@ -204,13 +204,13 @@ int VmbusChannelOpen(struct vmbus_channel *NewChannel, 
u32 SendRingBufferSize,
                                           RecvRingBufferSize) >> PAGE_SHIFT;
 
        ret = RingBufferInit(&NewChannel->Outbound, out, SendRingBufferSize);
-       if (!ret) {
+       if (ret != 0) {
                err = ret;
                goto errorout;
        }
 
        ret = RingBufferInit(&NewChannel->Inbound, in, RecvRingBufferSize);
-       if (!ret) {
+       if (ret != 0) {
                err = ret;
                goto errorout;
        }
@@ -228,7 +228,7 @@ int VmbusChannelOpen(struct vmbus_channel *NewChannel, u32 
SendRingBufferSize,
                                         RecvRingBufferSize,
                                         &NewChannel->RingBufferGpadlHandle);
 
-       if (!ret) {
+       if (ret != 0) {
                err = ret;
                goto errorout;
        }
@@ -569,7 +569,7 @@ int VmbusChannelEstablishGpadl(struct vmbus_channel 
*Channel, void *Kbuffer,
                        ret = VmbusPostMessage(gpadlBody,
                                               subMsgInfo->MessageSize -
                                               sizeof(*subMsgInfo));
-                       if (!ret)
+                       if (ret != 0)
                                goto Cleanup;
 
                }
-- 
1.6.3.2

Attachment: 0513-Fix-error-checking-in-channel.c.patch
Description: 0513-Fix-error-checking-in-channel.c.patch

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/virtualization

Reply via email to