On Mon, 13 Dec 2010, Hank Janssen wrote: > > > > -----Original Message----- > > From: Jesper Juhl [mailto:j...@chaosbits.net] > > Sent: Monday, December 13, 2010 12:48 PM > > You are leaking memory in the failure path. If for example one or two > > allocations succeed but one or two fail, then you'll leak the two successful > > allocations. > > > > I believe this should be > > > > if (!shut_txf_buf || !time_txf_buf || !hbeat_txf_buf) { > > printk(KERN_INFO > > "Unable to allocate memory for receive buffer\n"); > > kfree(hbeat_txf_buf); > > kfree(time_txf_buf); > > kfree(shut_txf_buf); > > return -ENOMEM; > > ... > > > > Oops, you are correct. Resubmitting the patch in a few minutes. > Ohh and another little detail; shouldn't this log message be a KERN_WARNING level message? And perhaps the log text should include "HyperV" or something so it's clear where it comes from..?
-- Jesper Juhl <j...@chaosbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
