On Tue, Feb 15, 2011 at 07:09:34PM +0000, Hank Janssen wrote: > > > > -----Original Message----- > > > From: Greg KH [mailto:gre...@suse.de] > > > Sent: Tuesday, February 15, 2011 9:23 AM > > > > Before the end of the week I will submit two patches for this; > > > > > > > > Remove DPRINT and change it to printk > > > > > > No, use dev_dbg() and friends instead of "raw" printk() calls. > > > > > > > Will do, you caught me just as I was starting the conversion :) > > While cleaning this up there are a few places in vmbus and channel behavior > where it is not in a device context. Are printk's okay in that context?
No, use pr_* instead for those. But those should be quite rare, as you should almost always have a device you are operating on, right? The reason you don't use "raw" printk() is the dev_dbg() and pr_debug() calls tie into the dynamic debugging core, which you want to use, as you don't want to roll your own special way of doing debugging. > The three drivers network/SCSI and Block of course will use dev_XX family. Good, but note, I think the network has their own version of this macro as well :) thanks, greg k-h _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
