On Wed, Feb 23, 2011 at 10:55:12PM +0000, Haiyang Zhang wrote: > > From: Greg KH [mailto:g...@kroah.com] > > The layering is almost ok, there is still one more layer here than is > > needed, and it should be removed (I already removed lots of layers that > > were not needed, just didn't get to this one.) But the naming also > > needs to be fixed up as it is wrong from a "driver model" standpoint > > with the rest of the kernel. > > So, how about rename the "struct driver_context" to "struct gen_drv_ctx" > in this patch? We can deal with the layering in next round of patches.
No, it's not a "driver context" at all. It is a "hyperv driver", so name it as such. A "context" is a void pointer or something that the driver uses privately. And you already have a pointer to the context in the base structure so you don't need your own. You should work on removing the layering now, that will clean this all up. thanks, greg k-h _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/virtualization
