> -----Original Message-----
> From: H Hartley Sweeten [mailto:hartl...@visionengravers.com]
> Sent: Wednesday, May 04, 2011 2:44 PM
> To: KY Srinivasan; gre...@suse.de; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; virtualizat...@lists.osdl.org
> Cc: Haiyang Zhang
> Subject: RE: [PATCH 1/1] Staging: hv: Add the necessary dependencies to hyperv
> Kconfig
> 
> On Wednesday, May 04, 2011 11:52 AM, K. Y. Srinivasan wrote:
> >
> > The vmbus driver dependes on ACPI and PCI subsystems. Change
> > Kconfig to reflect this.
> >
> > Signed-off-by: K. Y. Srinivasan <k...@microsoft.com>
> > Signed-off-by: Haiyang Zhang <haiya...@microsoft.com>
> > ---
> >  drivers/staging/hv/Kconfig |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/staging/hv/Kconfig b/drivers/staging/hv/Kconfig
> > index 76f0756..5e0c9f6 100644
> > --- a/drivers/staging/hv/Kconfig
> > +++ b/drivers/staging/hv/Kconfig
> > @@ -1,6 +1,6 @@
> >  config HYPERV
> >     tristate "Microsoft Hyper-V client drivers"
> > -   depends on X86 && m
> > +   depends on X86 && ACPI && PCI && m
> >     default n
> >     help
> >       Select this option to run Linux as a Hyper-V client operating
> 
> ACPI itself depends on PCI.  It also depends on IA64 || X86.  Will the
> vmbus driver work with IA64?  If so the depends on could just be:
> 
>       depends on ACPI && m

Good point; vmbus will not work on IA64 though. So, minimally we would want 
X86 && ACPI. I will resend this with this change.

Regards,

K. Y
> 
> Also, default n is redudant since n is the default anyway.
> 
> Regards,
> Hartley

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/virtualization

Reply via email to