On Sun, Jul 17, 2011 at 10:01:41PM +0200, Jesper Juhl wrote: > > @@ -28,10 +29,18 @@ > > > > #include "vhost.h" > > > > +static int zcopytx; > > +module_param(zcopytx, int, 0444); > > Should everyone be able to read this? How about "0440" just to be > paranoid? or?
I find it very helpful to have the parameter visible in sysfs. Given that: [mst@tuck linux-2.6]$ grep module_param drivers/net/*c|grep [64]44|wc -l 14 [mst@tuck linux-2.6]$ grep module_param drivers/net/*c|grep [64]40|wc -l 0 [mst@tuck linux-2.6]$ grep module_param drivers/net/*c|grep [64]00|wc -l 7 So at least the precedent is against 0440. What do you think? -- MST _______________________________________________ Virtualization mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/virtualization
