On Fri, Jul 29, 2011 at 09:56:19AM +0530, Amit Shah wrote: > On (Fri) 29 Jul 2011 [07:19:58], Michael S. Tsirkin wrote: > > On Thu, Jul 28, 2011 at 08:05:09PM +0530, Amit Shah wrote: > > > We don't allow port name changes dynamically for a port. So any > > > requests by the host to change the name are ignored. > > > > It would be nice to check the name and if > > changed, print a warning. > > But not change it, right?
That's what I meant. > I don't know what applications expect, but > I think we should keep the port names stable while they're plugged in. > > > > Before this patch, if the hypervisor sent a port name while we had one > > > set already, we would leak memory equivalent to the size of the old > > > name. > > > > > > This scenario wasn't expected so far, but with the suspend-resume > > > support, we'll send the VIRTIO_CONSOLE_PORT_READY message after restore, > > > which can get us into this situation. > > > > > > Signed-off-by: Amit Shah <[email protected]> > > > > Memleaks are bad. So this is a bugfix we probably should have anyway? > > Yes. > > Amit _______________________________________________ Virtualization mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/virtualization
