On Thu, Sep 08, Greg KH wrote:
> On Thu, Sep 08, 2011 at 06:26:50PM +0200, Olaf Hering wrote:
> > +++ b/drivers/staging/hv/storvsc_drv.c
> > @@ -1333,7 +1333,8 @@ static DEF_SCSI_QCMD(storvsc_queuecomman
> > /* Scsi driver */
> > static struct scsi_host_template scsi_driver = {
> > .module = THIS_MODULE,
> > - .name = "storvsc_host_t",
> > + .name = "hv_storvsc",
> > + .proc_name = "hv_storvsc",
>
> Shouldn't this be MODULE_NAME so it handles any potential name change in
> the future and makes it a bit more obvious as to what is going on here?
MODULE_NAME is just another define and appearently not used to assemble
a kernel module. Is DRV_NAME depreciated?
I think hv_storvsc and hv_netvsc should advertise their module names as
sysfs driver names. Digging into the hv history it could be that the
initial implementation had a storvsc.ko, and
c3260cfe8f08ca4564df61950cbebbb693aee292 introduced the hv_storvsc.ko
I will send a patch on top of that.
Olaf
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/virtualization
