On Thu, Sep 08, 2011 at 07:24:21AM -0700, K. Y. Srinivasan wrote: > Return proper error code in vmbus_remove(). > > Signed-off-by: K. Y. Srinivasan <[email protected]> > Signed-off-by: Haiyang Zhang <[email protected]> > --- > drivers/staging/hv/vmbus_drv.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c > index b9aeb76..95d33a4 100644 > --- a/drivers/staging/hv/vmbus_drv.c > +++ b/drivers/staging/hv/vmbus_drv.c > @@ -325,7 +325,7 @@ static int vmbus_probe(struct device *child_device) > */ > static int vmbus_remove(struct device *child_device) > { > - int ret; > + int ret = 0;
As remove functions can't fail, why return anything at all? Doesn't make sense, please fix. greg k-h _______________________________________________ Virtualization mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/virtualization
