> -----Original Message----- > From: Greg KH [mailto:[email protected]] > Sent: Friday, September 09, 2011 4:43 PM > To: KY Srinivasan > Cc: [email protected]; [email protected]; > [email protected]; [email protected]; Haiyang Zhang > Subject: Re: [PATCH 09/25] Staging: hv: util: Perform some service specific > de- > initialization in util_remove() > > On Thu, Sep 08, 2011 at 07:24:20AM -0700, K. Y. Srinivasan wrote: > > In preparation for modifying the util driver to fully conform to the > > Linux Driver Model, perform some service specific de-initialization in > > util_remove() as opposed to in exit_hyperv_utils() as is currently done. > > > > > > Signed-off-by: K. Y. Srinivasan <[email protected]> > > Signed-off-by: Haiyang Zhang <[email protected]> > > --- > > drivers/staging/hv/hv_util.c | 29 ++++++++++++++++++++++++----- > > 1 files changed, 24 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/staging/hv/hv_util.c b/drivers/staging/hv/hv_util.c > > index b86128a..2475ab2 100644 > > --- a/drivers/staging/hv/hv_util.c > > +++ b/drivers/staging/hv/hv_util.c > > @@ -291,6 +291,30 @@ error: > > static int util_remove(struct hv_device *dev, > > const struct hv_vmbus_device_id *dev_id) > > { > > + int service = dev_id->driver_data; > > + > > + switch (service) { > > + case HV_SHUTDOWN: > > + kfree(shut_txf_buf); > > + break; > > This switch and "static" pointers you need to free aren't needed at all > if you do this code logic correctly (i.e. a per-device buffer.) > > {sigh} > > I'm stopping reviewing now, this is making me grumpy, someone owes me a > bunch of beer...
Greg, I will rework this to be more on the lines of what you had suggested; and yes, I remember my original promise! I want to re-spin these patches and send it to you as soon as possible. Which tree can I clone to get your latest check-ins; kernel.org still seems to have issues this morning. Have you checked in Olaf's patches. Thanks, K. Y _______________________________________________ Virtualization mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/virtualization
