----- Original Message ----- > On Thu, Feb 16, 2012 at 01:16:25PM +0100, Andrew Jones wrote: > > We should hang onto bdev until we're done with it. > > Looks ok. Is there a BZ that sparked this? Thanks.
Nope. Just came across it while I was looking at the code. Drew > > > > Signed-off-by: Andrew Jones <[email protected]> > > --- > > drivers/block/xen-blkfront.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/block/xen-blkfront.c > > b/drivers/block/xen-blkfront.c > > index 2f22874..5d45688 100644 > > --- a/drivers/block/xen-blkfront.c > > +++ b/drivers/block/xen-blkfront.c > > @@ -1410,7 +1410,6 @@ static int blkif_release(struct gendisk > > *disk, fmode_t mode) > > mutex_lock(&blkfront_mutex); > > > > bdev = bdget_disk(disk, 0); > > - bdput(bdev); > > > > if (bdev->bd_openers) > > goto out; > > @@ -1441,6 +1440,7 @@ static int blkif_release(struct gendisk > > *disk, fmode_t mode) > > } > > > > out: > > + bdput(bdev); > > mutex_unlock(&blkfront_mutex); > > return 0; > > } > > -- > > 1.7.7.5 > > > > > > _______________________________________________ > > Xen-devel mailing list > > [email protected] > > http://lists.xensource.com/xen-devel > _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
