On 03/31/2012 07:54 AM, Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONT - Type 2] wrote:
On 3/30/2012 2:53 AM, Ren Mingxin wrote:

  Currently, block core has been supplied "disk_name_format()", so
we should remove duplicate function "rssd_disk_name_format()"
and use the new function to format rssd disk names.

Signed-off-by: Ren Mingxin<[email protected]>
---
  mtip32xx.c |   33 +--------------------------------
  1 file changed, 1 insertion(+), 32 deletions(-)

Looks fine.

Should the subject be "mtip32xx: ..." instead of "block: ..."? I
understand "block:" as relating to block core. I am fairly new here. If
"block:" can be used for block drivers too, that is fine too.



Good idea! Will be fixed in the next version.

--
Thanks,
Ren

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
  • [PATCH 0... Ren Mingxin
    • Re:... Michael S. Tsirkin
    • [PA... Ren Mingxin
    • [PA... Ren Mingxin
    • [PA... Ren Mingxin
      • ... Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONT - Type 2]
        • ... Ren Mingxin
    • [PA... Ren Mingxin
      • ... Asias He
        • ... Ren Mingxin
      • ... Tejun Heo
        • ... Tejun Heo
          • ... Ren Mingxin
            • ... Michael S. Tsirkin
              • ... Tejun Heo
                • ... James Bottomley

Reply via email to