On 2012-08-13 10:35, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger <[email protected]> > > This is required to get past the following assert with: > > commit 1523ed9e1d46b0b54540049d491475ccac7e6421 > Author: Jan Kiszka <[email protected]> > Date: Thu May 17 10:32:39 2012 -0300 > > virtio/vhost: Add support for KVM in-kernel MSI injection > > Cc: Stefan Hajnoczi <[email protected]> > Cc: Jan Kiszka <[email protected]> > Cc: Paolo Bonzini <[email protected]> > Cc: Anthony Liguori <[email protected]> > Signed-off-by: Nicholas Bellinger <[email protected]> > --- > hw/msix.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/hw/msix.c b/hw/msix.c > index 800fc32..c1e6dc3 100644 > --- a/hw/msix.c > +++ b/hw/msix.c > @@ -544,6 +544,9 @@ void msix_unset_vector_notifiers(PCIDevice *dev) > { > int vector; > > + if (!dev->msix_vector_use_notifier && !dev->msix_vector_release_notifier) > + return; > + > assert(dev->msix_vector_use_notifier && > dev->msix_vector_release_notifier); > >
I think to remember pointing out that there is a bug somewhere in the reset code which deactivates a non-active vhost instance, no? Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
