On Tue, Aug 21, 2012 at 7:31 PM, Blue Swirl <blauwir...@gmail.com> wrote:
> On Tue, Aug 21, 2012 at 8:23 AM, Cong Meng <m...@linux.vnet.ibm.com> wrote:
>> diff --git a/block_int.h b/block_int.h
>> index d72317f..a9d07a2 100644
>> --- a/block_int.h
>> +++ b/block_int.h
>> @@ -333,6 +333,10 @@ struct BlockDriverState {
>>
>> /* long-running background operation */
>> BlockJob *job;
>> +
>> + unsigned int max_sectors;
>
> With 32 bit ints and even with 4k sector size, the maximum disk size
> would be 16TB which may be soon exceeded by disks on the market.
> Please use 64 bit values, probably also for segment values below.
This doesn't specify device size, it specifies max sectors per I/O
request. When reviewing, I checked that the Linux kernel also uses
unsigned int for these fields.
Stefan
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
