On 10/09/12 10:03, Jan Beulich wrote: >>>> On 08.09.12 at 11:58, Dan Carpenter <[email protected]> wrote: >> When we use this pointer, we cast away the const modifier and modify the >> data. I think it was an accident to declare it as const. > > NAK - the const is very valid here, as the v2 interface (as opposed > to the v1 one) does _not_ modify this array (or if it does, it's a > bug). This is a guarantee made to user mode, so it should also be > expressed that way in the interface. > > But of course the cast used before this patch isn't right either, as > it indeed inappropriately discards the qualifier. Afaiu this was done > to simplify the internal workings of the code, but I don't think it's > desirable to sacrifice type safety for implementation simplicity.
m.arr here isn't const as m is really the V1 structure where m.arr is non-const. David _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
