Hi Greg, > > +EXPORT_SYMBOL(vmci_device_get); > > EXPORT_SYMBOL_GPL() for this, and all other exports?
We'd prefer to leave them as vanilla exports. While we're committed to open-sourcing everything, including our non-upstreamed drivers, we don't really have a strong opinion regarding consuming our exports in closed-source (general GPL issues aside). > And it seems that you have a bunch of "unused" parameters for this, > and other public functions. Please just remove them entirely. Will do. Also, regarding that particular public function, it seems to have slipped through the cracks. It's an artifact of the API being cross-platform prior to upstreaming. On Linux, it makes no sense whatsoever, so we'll just yank it completely. Thanks! - Andy _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
