On 02/14/13 10:45, Randy Dunlap wrote:
> On 02/13/13 19:00, Rusty Russell wrote:
>> Randy Dunlap <rdun...@infradead.org> writes:
>>
>>> On 02/13/13 00:35, Stephen Rothwell wrote:
>>>> Hi all,
>>>>
>>>> Changes since 20130212:
>>>
>>> on i386:
>>>
>>> drivers/built-in.o: In function `in_intr':
>>> virtio_console.c:(.text+0x2dd31): undefined reference to `hvc_poll'
>>> virtio_console.c:(.text+0x2dd41): undefined reference to `hvc_kick'
>>> drivers/built-in.o: In function `resize_console':
>>> virtio_console.c:(.text+0x2e26f): undefined reference to `__hvc_resize'
>>> drivers/built-in.o: In function `unplug_port':
>>> virtio_console.c:(.text+0x2e572): undefined reference to `hvc_remove'
>>> drivers/built-in.o: In function `init_port_console':
>>> (.text+0x2fe59): undefined reference to `hvc_alloc'
>>> drivers/built-in.o: In function `virtio_cons_early_init':
>>> (.init.text+0x16d1): undefined reference to `hvc_instantiate'
>>>
>>>
>>> Full randconfig file is attached.
>>
>> This looks like an impossible config. CONFIG_VIRTIO_CONSOLE=y, but
>> CONFIG_HVC_DRIVER isn't set.
>>
>> From drivers/char/Kconfig:
>>
>> config VIRTIO_CONSOLE
>> tristate "Virtio console"
>> depends on VIRTIO
>> select HVC_DRIVER
>>
>> ???
>
> OK. It's probably yet another stinking problem with kvmtool and randconfig.
> Running *config reports:
>
> warning: (KVMTOOL_TEST_ENABLE && LGUEST_GUEST) selects VIRTIO_CONSOLE which
> has unmet direct dependencies (VIRTIO && TTY)
>
>
> I'll look a bit more...
Nope, that's not it. Stephen's comments were much closer.
The patch below fixes the kconfig warning and the build errors.
---
From: Randy Dunlap <rdun...@infradead.org>
Fix kconfig warning for LGUEST_GUEST config by selecting TTY:
warning: (KVMTOOL_TEST_ENABLE && LGUEST_GUEST) selects VIRTIO_CONSOLE which has
unmet direct dependencies (VIRTIO && TTY)
Signed-off-by: Randy Dunlap <rdun...@infradead.org>
---
arch/x86/lguest/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20130213.orig/arch/x86/lguest/Kconfig
+++ linux-next-20130213/arch/x86/lguest/Kconfig
@@ -2,6 +2,7 @@ config LGUEST_GUEST
bool "Lguest guest support"
select PARAVIRT
depends on X86_32
+ select TTY
select VIRTUALIZATION
select VIRTIO
select VIRTIO_CONSOLE
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
