On Thu, 2013-03-21 at 08:29 +0000, Rusty Russell wrote: > diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c > index d933150..84ef5fc 100644 > --- a/drivers/virtio/virtio_mmio.c > +++ b/drivers/virtio/virtio_mmio.c [...] > static void vm_finalize_features(struct virtio_device *vdev) > @@ -160,7 +162,9 @@ static void vm_finalize_features(struct virtio_device > *vdev) > vring_transport_features(vdev); > > writel(0, vm_dev->base + VIRTIO_MMIO_GUEST_FEATURES_SEL); > - writel(vdev->features, vm_dev->base + VIRTIO_MMIO_GUEST_FEATURES); > + writel((u32)vdev->features, vm_dev->base + VIRTIO_MMIO_GUEST_FEATURES); > + writel(1, vm_dev->base + VIRTIO_MMIO_GUEST_FEATURES_SEL); > + writel(vdev->features >> 32, vm_dev->base + VIRTIO_MMIO_GUEST_FEATURES);
Maybe (u32)(vdev->features >> 32), just to keep the lines consistent? I'm just being fussy... ;-) > } Otherwise perfectly fine with me (together with "04/22 virtio: use u32, not bitmap for struct virtio_device's features") Acked-by: Pawel Moll <[email protected]> Pawel _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
