Heinz Graalfs <[email protected]> writes: > This patch adds 2 new functions: > > virtqueue_set_broken(): to be called when a virtqueue kick operation fails. > > virtqueue_is_broken(): can be called to query the virtqueue state after a host > was kicked. > > Signed-off-by: Heinz Graalfs <[email protected]>
Thanks for doing this! But as shown by the following patches, the separation of kick and broken test is a bad API. We should make virtqueue_kick() and virtqueue_notify() return a bool (ie. vq->broken). We'll still need virtqueue_is_broken(), as it would be nice to make all callers to virtqueue_get_buf() check it as well. Cheers, Rusty. _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
