On 10/30/2013 03:22 PM, Kees Cook wrote:
>>
>> - /*
>> - * sizeof(unsigned long) coming from an extra "long" at the end
>> - * of the iobitmap. See tss_struct definition in processor.h
>> - *
>> - * -1? seg base+limit should be pointing to the address of the
>> - * last valid byte
>
> I think it might be better to keep at least a minimal comment near the
> TSS_LIMIT declaration, just to explain the "-1" part, which is not
> entirely obvious from just reading the code.
>
Agreed, although it doesn't need to be an unsigned long at all... the
CPU will only ever access one extra byte past the end.
-hpa
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
