On Tue, Nov 19, 2013 at 01:38:16PM -0800, Michael Dalton wrote: > Great catch Jason. I agree this now raises the larger issue of how to > handle a memory alloc failure in the middle of receive. As Eric mentioned, > we can drop the packet and free the remaining (num_buf) frags. > > Michael, perhaps I'm missing something, but why would you prefer > pre-allocating buffers in this case? If the guest kernel is OOM'ing, > dropping packets should provide backpressure. > > Also, we could just as easily fail the initial skb alloc in page_to_skb, > and I think that case also needs to be handled now in the same fashion as > a memory allocation failure in receive_mergeable. > > Best, > > Mike
Yes I missed this last night. Thanks a lot Eric and Michael for pointing this out. _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
