On Tue, 2014-05-20 at 10:35 +0200, Paolo Bonzini wrote: > Il 19/05/2014 21:07, Nicholas A. Bellinger ha scritto: > > Hi MST, > > > > So I've finally got some cycles to get back to this code, and wanted to > > verify the outstanding items you had previously raised: > > > > - Convert vhost-scsi to be independent of IOV layout using > > memcpy_fromiovecend. (Does this effect existing non PI virtio-scsi > > operation..?) > > - Report VIRTIO_F_ANY_LAYOUT feature bit to userspace. > > - Convert virtio_scsi_cmd_req_pi to bytes field instead of number of > > iovecs. > > This is the only item really required, since the bytes field is what > will be in VIRTIO 1.0. The other would be nice to have, but not a > blocker for PI support. > > > - Ensure virtio_scsi_cmd_req_pi is naturally aligned > > mst already commented on this. > > > - Figure out why QEMU is not acking (any) vhost-scsi feature bits > > This is a separate bug, isn't it? It need not block PI support. >
Thanks for the feedback. I'll get the series updated to use bytes instead of number of iovecs in virtio_scsi_cmd_req_pi, along with a simple memcpy_fromiovecend conversion. --nab _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
