On Thu, 2014-10-30 at 11:47 -0700, Eric Dumazet wrote:
> On Thu, 2014-10-30 at 18:27 +0000, Ben Hutchings wrote:
> 
> 
> > +           {
> > +                   static bool warned;
> > +
> > +                   if (!warned) {
> > +                           warned = true;
> > +                           netdev_warn(tun->dev,
> > +                                       "%s: using disabled UFO feature; 
> > please fix this program\n",
> > +                                       current->comm);
> > +                   }
> >
> 
> It might be time to add netdev_warn_once() ;)

Could do.  I'm trying to make small fixes that are suitable for stable.

> Alternatively, you could use 
>       pr_warn_once("%s: using disabled UFO feature; please fix this 
> program\n",
>                    tun->dev->name, current->comm);

That's missing a "%s: ", but yes that would also work.

Ben.

-- 
Ben Hutchings
The program is absolutely right; therefore, the computer must be wrong.

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Reply via email to