On Tue, Jan 20, 2015 at 05:51:11PM +0000, Pawel Moll wrote: > On Tue, 2015-01-20 at 17:44 +0000, Michael S. Tsirkin wrote: > > Good. But your current code will also try to support a mix: device that > > uses the new transport underneath, but old layout and semantics on top. > > It will not try to support the mix, but rather will not stop it from > working. > > > This has no value: the spec does *not* define such devices > > and it also does not match any hosts, so this just adds to support matrix. > > And if linux supports it, someone *will* ship such a > > device and we'll be stuck with it forever. > > > > So please, detect out of spec devices and fail gracefully. > > pci and s390 do this already. > > Ok, let it be. Will send v2 in a second. > > Pawel
Thanks! The relevant functions are finalize_features (to check feature bit) and probe (to check is_legacy). -- MST _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
