Commit-ID: 35b69a420bfb56b7b74cb635ea903db05e357bec Gitweb: https://git.kernel.org/tip/35b69a420bfb56b7b74cb635ea903db05e357bec Author: Michael Kelley <mikel...@microsoft.com> AuthorDate: Sun, 4 Nov 2018 03:48:54 +0000 Committer: Thomas Gleixner <t...@linutronix.de> CommitDate: Sun, 4 Nov 2018 11:04:46 +0100
clockevents/drivers/i8253: Add support for PIT shutdown quirk Add support for platforms where pit_shutdown() doesn't work because of a quirk in the PIT emulation. On these platforms setting the counter register to zero causes the PIT to start running again, negating the shutdown. Provide a global variable that controls whether the counter register is zero'ed, which platform specific code can override. Signed-off-by: Michael Kelley <mikel...@microsoft.com> Signed-off-by: Thomas Gleixner <t...@linutronix.de> Cc: "gre...@linuxfoundation.org" <gre...@linuxfoundation.org> Cc: "de...@linuxdriverproject.org" <de...@linuxdriverproject.org> Cc: "daniel.lezc...@linaro.org" <daniel.lezc...@linaro.org> Cc: "virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org> Cc: "jgr...@suse.com" <jgr...@suse.com> Cc: "akata...@vmware.com" <akata...@vmware.com> Cc: "o...@aepfle.de" <o...@aepfle.de> Cc: "a...@canonical.com" <a...@canonical.com> Cc: vkuznets <vkuzn...@redhat.com> Cc: "jasow...@redhat.com" <jasow...@redhat.com> Cc: "marcelo.ce...@canonical.com" <marcelo.ce...@canonical.com> Cc: KY Srinivasan <k...@microsoft.com> Cc: sta...@vger.kernel.org Link: https://lkml.kernel.org/r/1541303219-11142-2-git-send-email-mikel...@microsoft.com --- drivers/clocksource/i8253.c | 14 ++++++++++++-- include/linux/i8253.h | 1 + 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/clocksource/i8253.c b/drivers/clocksource/i8253.c index 9c38895542f4..d4350bb10b83 100644 --- a/drivers/clocksource/i8253.c +++ b/drivers/clocksource/i8253.c @@ -20,6 +20,13 @@ DEFINE_RAW_SPINLOCK(i8253_lock); EXPORT_SYMBOL(i8253_lock); +/* + * Handle PIT quirk in pit_shutdown() where zeroing the counter register + * restarts the PIT, negating the shutdown. On platforms with the quirk, + * platform specific code can set this to false. + */ +bool i8253_clear_counter_on_shutdown __ro_after_init = true; + #ifdef CONFIG_CLKSRC_I8253 /* * Since the PIT overflows every tick, its not very useful @@ -109,8 +116,11 @@ static int pit_shutdown(struct clock_event_device *evt) raw_spin_lock(&i8253_lock); outb_p(0x30, PIT_MODE); - outb_p(0, PIT_CH0); - outb_p(0, PIT_CH0); + + if (i8253_clear_counter_on_shutdown) { + outb_p(0, PIT_CH0); + outb_p(0, PIT_CH0); + } raw_spin_unlock(&i8253_lock); return 0; diff --git a/include/linux/i8253.h b/include/linux/i8253.h index e6bb36a97519..8336b2f6f834 100644 --- a/include/linux/i8253.h +++ b/include/linux/i8253.h @@ -21,6 +21,7 @@ #define PIT_LATCH ((PIT_TICK_RATE + HZ/2) / HZ) extern raw_spinlock_t i8253_lock; +extern bool i8253_clear_counter_on_shutdown; extern struct clock_event_device i8253_clockevent; extern void clockevent_i8253_init(bool oneshot); _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
