Fri, Mar 29, 2019 at 04:15:12PM CET, [email protected] wrote:
>On Thu, 28 Mar 2019 19:47:27 -0400
>Si-Wei Liu <[email protected]> wrote:
>
>> +    if (unlikely(dev->flags & IFF_UP)) {
>> +            struct netdev_notifier_change_info change_info;
>> +
>> +            change_info.flags_changed = 0;
>
>Simpler to use structure initialization, which also avoid any chance
>of unititialized fields.
>
>               struct netdev_notifier_change_info change_info
>                       = { .flags_changed =  0 };
 
In fact, you can do just:
        struct netdev_notifier_change_info change_info = {};
to achieve the same.
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Reply via email to