On Wed, 12 Jun 2019 16:35:01 +0200
Cornelia Huck <[email protected]> wrote:

> On Wed, 12 Jun 2019 13:12:32 +0200
> Halil Pasic <[email protected]> wrote:

[..]

> > --- a/drivers/s390/cio/css.c
> > +++ b/drivers/s390/cio/css.c
> > @@ -1184,6 +1184,7 @@ static int __init css_bus_init(void)
> >     ret = cio_dma_pool_init();
> >     if (ret)
> >             goto out_unregister_pmn;
> > +   airq_init();
> 
> Ignoring the return code here does not really hurt right now, but we
> probably want to change that if we want to consider failures in css
> initialization to be fatal.
> 

Right. I think that would even simplify the code a bit (no rollback).

> >     css_init_done = 1;
> >  
> >     /* Enable default isc for I/O subchannels. */
> 
> On the whole, not really anything that needs changes right now, so have
> a
> 
> Reviewed-by: Cornelia Huck <[email protected]>
> 

Thank you so much!

Regards,
Halil

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Reply via email to