Re: [PATCH -next] virtio: vdpa: remove unused variables 'ifcvf' and 'ifcvf_lm'

[Jason Wang]

On 2020/3/31 下午4:02, YueHaibing wrote:

drivers/virtio/vdpa/ifcvf/ifcvf_main.c:34:24:
  warning: variable ‘ifcvf’ set but not used [-Wunused-but-set-variable]
drivers/virtio/vdpa/ifcvf/ifcvf_base.c:304:31:
  warning: variable ‘ifcvf_lm’ set but not used [-Wunused-but-set-variable]

Reported-by: Hulk Robot <hul...@huawei.com>
Signed-off-by: YueHaibing <yuehaib...@huawei.com>

Acked-by: Jason Wang <jasow...@redhat.com>

Thanks

---
  drivers/virtio/vdpa/ifcvf/ifcvf_base.c | 2 --
  drivers/virtio/vdpa/ifcvf/ifcvf_main.c | 2 --
  2 files changed, 4 deletions(-)

diff --git a/drivers/virtio/vdpa/ifcvf/ifcvf_base.c 
b/drivers/virtio/vdpa/ifcvf/ifcvf_base.c
index b61b06ea26d3..e24371d644b5 100644
--- a/drivers/virtio/vdpa/ifcvf/ifcvf_base.c
+++ b/drivers/virtio/vdpa/ifcvf/ifcvf_base.c
@@ -301,12 +301,10 @@ int ifcvf_set_vq_state(struct ifcvf_hw *hw, u16 qid, u64 
num)

static int ifcvf_hw_enable(struct ifcvf_hw *hw)

  {
-       struct ifcvf_lm_cfg __iomem *ifcvf_lm;
        struct virtio_pci_common_cfg __iomem *cfg;
        struct ifcvf_adapter *ifcvf;
        u32 i;

- ifcvf_lm = (struct ifcvf_lm_cfg __iomem *)hw->lm_cfg;

        ifcvf = vf_to_adapter(hw);
        cfg = hw->common_cfg;
        ifc_iowrite16(IFCVF_MSI_CONFIG_OFF, &cfg->msix_config);
diff --git a/drivers/virtio/vdpa/ifcvf/ifcvf_main.c 
b/drivers/virtio/vdpa/ifcvf/ifcvf_main.c
index 8d54dc5b08d2..28d9e5de5675 100644
--- a/drivers/virtio/vdpa/ifcvf/ifcvf_main.c
+++ b/drivers/virtio/vdpa/ifcvf/ifcvf_main.c
@@ -31,11 +31,9 @@ static irqreturn_t ifcvf_intr_handler(int irq, void *arg)
  static int ifcvf_start_datapath(void *private)
  {
        struct ifcvf_hw *vf = ifcvf_private_to_vf(private);
-       struct ifcvf_adapter *ifcvf;
        u8 status;
        int ret;

- ifcvf = vf_to_adapter(vf);

        vf->nr_vring = IFCVF_MAX_QUEUE_PAIRS * 2;
        ret = ifcvf_start_hw(vf);
        if (ret < 0) {

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization