Hi Michael,
On Sun, Apr 5, 2020 at 10:17 AM Michael S. Tsirkin <[email protected]> wrote:
>
> set_dma_ops isn't available on all architectures:
>
> make ARCH=um
> ...
>
> drivers/vdpa/vdpa_sim/vdpa_sim.c: In function 'vdpasim_create':
> >> drivers/vdpa/vdpa_sim/vdpa_sim.c:324:2: error: implicit declaration of
> >> function 'set_dma_ops'; did you mean 'set_groups'?
> +[-Werror=implicit-function-declaration]
> set_dma_ops(dev, &vdpasim_dma_ops);
> ^~~~~~~~~~~
> set_groups
>
> Signed-off-by: Michael S. Tsirkin <[email protected]>
As this fixes the Sun-3 all{mod,yes}-config build, which has NO_DMA=y:
Acked-by: Geert Uytterhoeven <[email protected]>
However, you may want to follow Christoph's suggestion instead.
> --- a/drivers/vdpa/Kconfig
> +++ b/drivers/vdpa/Kconfig
> @@ -14,7 +14,7 @@ if VDPA_MENU
>
> config VDPA_SIM
> tristate "vDPA device simulator"
> - depends on RUNTIME_TESTING_MENU
> + depends on RUNTIME_TESTING_MENU && HAS_DMA
> select VDPA
> select VHOST_RING
> select VHOST_IOTLB
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
