Re: [PATCH -next v2 resend] drm/bochs: Fix missing pci_disable_device() on error in bochs_pci_probe()

[Thomas Zimmermann]

Hi

Am 15.07.21 um 15:28 schrieb Yang Yingliang:

Replace pci_enable_device() with pcim_enable_device(),
pci_disable_device() will be called in release automatically.

v2:
   use pcim_enable_device()

Signed-off-by: Yang Yingliang <yangyingli...@huawei.com>
Reported-by: Hulk Robot <hul...@huawei.com>
Acked-by: Thomas Zimmermann <tzimmerm...@suse.de>

Best regards
Thomas

Thanks, I'll merge it into drm-misc-next as v3. I also had to update the path to the bochs driver meanwhile.

---
  drivers/gpu/drm/bochs/bochs_drv.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bochs/bochs_drv.c 
b/drivers/gpu/drm/bochs/bochs_drv.c
index c828cadbabff..8065c9537237 100644
--- a/drivers/gpu/drm/bochs/bochs_drv.c
+++ b/drivers/gpu/drm/bochs/bochs_drv.c
@@ -118,7 +118,7 @@ static int bochs_pci_probe(struct pci_dev *pdev,
        if (IS_ERR(dev))
                return PTR_ERR(dev);

+       ret = pcim_enable_device(pdev);
        if (ret)
                goto err_free_dev;

- ret = pci_enable_device(pdev);

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

OpenPGP_signature
Description: OpenPGP digital signature

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization