RE: [PATCH linux-next v3 0/6] vdpa: enable user to set mac, mtu

[Parav Pandit via Virtualization]

> From: Jason Wang <jasow...@redhat.com>
> Sent: Wednesday, August 18, 2021 10:02 AM
> On Wed, Aug 18, 2021 at 11:15 AM Parav Pandit <pa...@nvidia.com> wrote:
[..]
> > > I'm inclined to say vxlan is closer to a model to follow.
> > Ok. thanks for the feedback. We are using the model close to vxlan.
> > Lets resolve should we have it at creation time, post creation or both?
> > (a) Creation time
> > Pros:
> > - simpler single api for user
> > - eliminates needs of inventing stats reset in future series
> > Cons:
> > - inability to reuse the device with different config
> 
> This can be solved by destroying the instance and re-creating it with a
> different params?
> 
Yes, which is what I tried be say below.

> > - This may not be of great advantage, and it is probably fine to have 
> > creation time params
      ^^^^^ here.

> >
> > (b) post creation time:
> > Pros:
> > - able to reuse the device with different config for say different VM.
> > - will require stats reset in future once stats are implemented
> 
> Any reason for doing this other than re-creating the device?
> 
No. Only reason I can think of is, device reconfig may be faster than recreate.
But I weigh user simplicity more at the beginning and optimizations to bring 
later if required.

> > Cons:
> > - more commands for users to config a device, better to have the ability at
> create time.
> 
> We probably need to support post creation but it should be device specific.

True. Your below device resize is good example of it.

> 
> E.g we may support device resize for virtio-blk devices.
> 
> But it can be done on top I think.
I think so too.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization