Hello David Hildenbrand,
The patch 6cc26d77613a: "virtio-mem: use page_offline_(start|end)
when setting PageOffline()" from Jun 30, 2021, leads to the following
Smatch static checker warning:
drivers/virtio/virtio_mem.c:1072 virtio_mem_set_fake_offline()
warn: sleeping in atomic context
drivers/virtio/virtio_mem.c
1069 static void virtio_mem_set_fake_offline(unsigned long pfn,
1070 unsigned long nr_pages, bool
onlined)
1071 {
--> 1072 page_offline_begin();
virtio_mem_online_page_cb() is holding rcu_read_lock() so calling
page_offline_begin() here is sleeping in atomic bug.
1073 for (; nr_pages--; pfn++) {
1074 struct page *page = pfn_to_page(pfn);
1075
1076 __SetPageOffline(page);
1077 if (!onlined) {
1078 SetPageDirty(page);
1079 /* FIXME: remove after cleanups */
1080 ClearPageReserved(page);
1081 }
1082 }
1083 page_offline_end();
1084 }
regards,
dan carpenter
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
