On Mon, Sep 6, 2021 at 10:22 PM Xie Yongji <[email protected]> wrote: > > We should cleanup the old kernel states e.g. interrupt callback > no matter whether the userspace handle the reset correctly or not > since virtio-vdpa can't handle the reset failure now. > > Otherwise, the old state might be used after reset which might > break something, e.g. the old interrupt callback might be triggered > by userspace after reset, which can break the virtio device driver. > > Signed-off-by: Xie Yongji <[email protected]> > --- > drivers/vdpa/vdpa_user/vduse_dev.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c > b/drivers/vdpa/vdpa_user/vduse_dev.c > index 59a93e5b967a..61695521066c 100644 > --- a/drivers/vdpa/vdpa_user/vduse_dev.c > +++ b/drivers/vdpa/vdpa_user/vduse_dev.c > @@ -665,13 +665,11 @@ static void vduse_vdpa_set_config(struct vdpa_device > *vdpa, unsigned int offset, > static int vduse_vdpa_reset(struct vdpa_device *vdpa) > { > struct vduse_dev *dev = vdpa_to_vduse(vdpa); > - > - if (vduse_dev_set_status(dev, 0)) > - return -EIO; > + int ret = vduse_dev_set_status(dev, 0); > > vduse_dev_reset(dev); > > - return 0; > + return ret; > } > > static u32 vduse_vdpa_get_generation(struct vdpa_device *vdpa) > -- > 2.11.0 >
Acked-by: Jason Wang <[email protected]> _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
