On Wed, Oct 27, 2021 at 1:56 AM Parav Pandit <[email protected]> wrote: > > Cited patch in the fixes tag clears the features bit during reset. > mlx5 vdpa device feature bits are static decided by device capabilities. > These feature bits (including VIRTIO_NET_F_MAC) are initialized during > device addition time. > > Clearing features bit in reset callback cleared the VIRTIO_NET_F_MAC. Due > to this, MAC address provided by the device is not honored. > > Fix it by not clearing the static feature bits during reset. > > Fixes: 0686082dbf7a ("vdpa: Add reset callback in vdpa_config_ops") > Signed-off-by: Parav Pandit <[email protected]> > Reviewed-by: Eli Cohen <[email protected]>
Acked-by: Jason Wang <[email protected]> > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c > b/drivers/vdpa/mlx5/net/mlx5_vnet.c > index 6bbdc0ece707..8d1539728a59 100644 > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c > @@ -2194,7 +2194,6 @@ static int mlx5_vdpa_reset(struct vdpa_device *vdev) > clear_vqs_ready(ndev); > mlx5_vdpa_destroy_mr(&ndev->mvdev); > ndev->mvdev.status = 0; > - ndev->mvdev.mlx_features = 0; > memset(ndev->event_cbs, 0, sizeof(ndev->event_cbs)); > ndev->mvdev.actual_features = 0; > ++mvdev->generation; > -- > 2.25.4 > _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
