On Thu, Nov 25, 2021 at 09:01:26AM +0200, Eli Cohen wrote:
> On Wed, Nov 24, 2021 at 03:55:34PM -0800, Si-Wei Liu wrote:
> > 
> > 
> > On 11/24/2021 9:19 AM, Eli Cohen wrote:
> > > Increase the limit on the maximum number of supported virtqueues to 256
> > > to match hardware capabilities.
> > > 
> > > Signed-off-by: Eli Cohen <[email protected]>
> > Acked-by: Si-Wei Liu <[email protected]>
> > > ---
> > >   drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c 
> > > b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > index ed7a63e48335..8f2918a8efc6 100644
> > > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > @@ -135,7 +135,7 @@ struct mlx5_vdpa_virtqueue {
> > >   /* We will remove this limitation once mlx5_vdpa_alloc_resources()
> > >    * provides for driver space allocation
> > >    */
> > > -#define MLX5_MAX_SUPPORTED_VQS 16
> > > +#define MLX5_MAX_SUPPORTED_VQS 256
> > Did we check how much increase of memory footprint ended up with on struct
> > mlx5_vdpa_net?
> > 
> 
> The grow is 1048 * 240 = 251520 bytes.


Pls include this info in the commit log.

> > -Siwei
> > 
> > >   static bool is_index_valid(struct mlx5_vdpa_dev *mvdev, u16 idx)
> > >   {
> > 

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Reply via email to