On Tue, Dec 7, 2021 at 10:45 AM Mike Christie <[email protected]> wrote: > > From: Andrey Ryabinin <[email protected]> > > vhost_vsock_flush() calls vhost_work_dev_flush(vsock->vqs[i].poll.dev) > before vhost_work_dev_flush(&vsock->dev). This seems pointless > as vsock->vqs[i].poll.dev is the same as &vsock->dev and several flushes > in a row doesn't do anything useful, one is just enough. > > Signed-off-by: Andrey Ryabinin <[email protected]> > Reviewed-by: Stefano Garzarella <[email protected]> > Signed-off-by: Mike Christie <[email protected]> > --- > drivers/vhost/vsock.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c > index 2339587bcd31..1f38160b249d 100644 > --- a/drivers/vhost/vsock.c > +++ b/drivers/vhost/vsock.c > @@ -703,11 +703,6 @@ static int vhost_vsock_dev_open(struct inode *inode, > struct file *file) > > static void vhost_vsock_flush(struct vhost_vsock *vsock) > { > - int i; > - > - for (i = 0; i < ARRAY_SIZE(vsock->vqs); i++) > - if (vsock->vqs[i].handle_kick) > - vhost_work_dev_flush(vsock->vqs[i].poll.dev); > vhost_work_dev_flush(&vsock->dev); > }
Is this better to be consistent with vhost-net so that we can simply remove the vhost_vsock_flush() wrapper here. Thanks > > -- > 2.25.1 > _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
