> -----Original Message----- > From: zhenwei pi [mailto:pizhen...@bytedance.com] > Sent: Thursday, February 10, 2022 4:18 PM > To: Gonglei (Arei) <arei.gong...@huawei.com> > Cc: jasow...@redhat.com; virtualization@lists.linux-foundation.org; > linux-cry...@vger.kernel.org; linux-ker...@vger.kernel.org; > helei.si...@bytedance.com; m...@redhat.com > Subject: Re: RE: [PATCH 2/3] virtio-crypto: introduce akcipher service > > >> /* The accelerator hardware is ready */ #define > >> VIRTIO_CRYPTO_S_HW_READY (1 << 0) @@ -442,6 +520,7 @@ struct > >> virtio_crypto_config { > >> __le32 reserve; > >> /* Maximum size of each crypto request's content */ > >> __le64 max_size; > >> + __le32 akcipher_algo; > >> }; > >> > > You can use the reserve attribute. Keeping 64-bit aligned. > > > >> struct virtio_crypto_inhdr { > >> -- > >> 2.25.1 > > > > Can I use the "__le32 reserve;" field directly? > > struct virtio_crypto_config { > /* See VIRTIO_CRYPTO_OP_* above */ > __le32 status; > > /* > * Maximum number of data queue > */ > __le32 max_dataqueues; > > /* > * Specifies the services mask which the device support, > * see VIRTIO_CRYPTO_SERVICE_* above > */ > __le32 crypto_services; > > /* Detailed algorithms mask */ > __le32 cipher_algo_l; > __le32 cipher_algo_h; > __le32 hash_algo; > __le32 mac_algo_l; > __le32 mac_algo_h; > __le32 aead_algo; > /* Maximum length of cipher key */ > __le32 max_cipher_key_len; > /* Maximum length of authenticated key */ > __le32 max_auth_key_len; > __le32 reserve; --> __le32 akcipher_algo; > /* Maximum size of each crypto request's content */ > __le64 max_size; > }; > Yes, I think so. Otherwise you will add other reserved field :( Regards, -Gonglei _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
RE: RE: [PATCH 2/3] virtio-crypto: introduce akcipher service
Gonglei (Arei) via Virtualization Thu, 10 Feb 2022 01:21:30 -0800
- [PATCH 0/3] Introduce akcipher service f... zhenwei pi
- [PATCH 1/3] virtio_crypto: Introduc... zhenwei pi
- RE: [PATCH 1/3] virtio_crypto: ... Gonglei (Arei) via Virtualization
- [PATCH 2/3] virtio-crypto: introduc... zhenwei pi
- RE: [PATCH 2/3] virtio-crypto: ... Gonglei (Arei) via Virtualization
- Re: RE: [PATCH 2/3] virtio-... zhenwei pi
- RE: RE: [PATCH 2/3] vir... Gonglei (Arei) via Virtualization
- [PATCH 3/3] virtio-crypto: implemen... zhenwei pi
- Re: [PATCH 3/3] virtio-crypto: ... kernel test robot
- [RFC PATCH] virtio-crypto: virt... kernel test robot
- Re: [PATCH 3/3] virtio-crypto: ... kernel test robot
- Re: [PATCH 3/3] virtio-crypto: ... kernel test robot
- Re: [PATCH 3/3] virtio-crypto: ... kernel test robot
- PING: [PATCH 0/3] Introduce akciphe... zhenwei pi
- Re: PING: [PATCH 0/3] Introduce... Jason Wang
- Re: PING: [PATCH 0/3] Intro... Michael S. Tsirkin