> -----Original Message----- > From: Christophe JAILLET [mailto:[email protected]] > Sent: Sunday, May 22, 2022 9:07 PM > To: [email protected]; Gonglei (Arei) <[email protected]>; > Michael S. Tsirkin <[email protected]>; Jason Wang <[email protected]>; > Herbert Xu <[email protected]>; David S. Miller > <[email protected]>; zhenwei pi <[email protected]> > Cc: [email protected]; [email protected]; Christophe > JAILLET <[email protected]>; > [email protected]; [email protected] > Subject: [PATCH] virtio-crypto: Fix an error handling path in > virtio_crypto_alg_skcipher_close_session() > > Now that a private buffer is allocated (see commit in the Fixes tag), it must > be > released in all error handling paths. > > Add the missing goto to avoid a leak in the error handling path. > > Fixes: 42e6ac99e417 ("virtio-crypto: use private buffer for control request") > Signed-off-by: Christophe JAILLET <[email protected]> > --- > drivers/crypto/virtio/virtio_crypto_skcipher_algs.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Gonglei <[email protected]> Regards, -Gonglei > diff --git a/drivers/crypto/virtio/virtio_crypto_skcipher_algs.c > b/drivers/crypto/virtio/virtio_crypto_skcipher_algs.c > index e553ccadbcbc..e5876286828b 100644 > --- a/drivers/crypto/virtio/virtio_crypto_skcipher_algs.c > +++ b/drivers/crypto/virtio/virtio_crypto_skcipher_algs.c > @@ -239,7 +239,8 @@ static int virtio_crypto_alg_skcipher_close_session( > pr_err("virtio_crypto: Close session failed status: %u, > session_id: > 0x%llx\n", > ctrl_status->status, destroy_session->session_id); > > - return -EINVAL; > + err = -EINVAL; > + goto out; > } > > err = 0; > -- > 2.34.1 _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
RE: [PATCH] virtio-crypto: Fix an error handling path in virtio_crypto_alg_skcipher_close_session()
Gonglei (Arei) via Virtualization Sun, 22 May 2022 20:30:27 -0700
- Re: [PATCH] virtio-crypto: Fix an error ... zhenwei pi
- RE: [PATCH] virtio-crypto: Fix an e... Gonglei (Arei) via Virtualization
- Re: [PATCH] virtio-crypto: Fix an e... Jason Wang
